Missing splines dependency.

[ddiez]

This is a nice way in which I can give you comments using GitHub tools without polluting the code with them. You can browse the code in Github and choose a line and then copy a permalink or even directly create an issue that you can then review. Once this is "done", you can close it, helping you to keep track of things.

My comment:

When I tried your package it complain about the function bs not found. You need to add a dependency to the package splines so that you get access to its NAMESPACE (i.e. to its exported functions). The way to do so is to add a line in DESCRIPTION (maybe on top of the line I referred in this issue):

Imports: splines

and then in NAMESPACE:

import(splines)

The one in DESCRIPTION states that your package uses splines. The second imports all the NAMESPACE. You may want to import just one function, in which case you use instead:

importFrom(splines, bs)

https://github.com/alexisvdb/single-cell-haystack/blob/66dfd1d37c9d210eb2f5de0816b11e41f02302e0/DESCRIPTION#L12

https://github.com/alexisvdb/single-cell-haystack/blob/66dfd1d37c9d210eb2f5de0816b11e41f02302e0/NAMESPACE#L2

[ddiez]

And we can keep the conversation related to this issue here, which makes things easier than using email or Slack.

[alexisvdb]

I added the splines dependency in the NAMESPACE and DESCRIPTION files. I did the same for ggplot2 and reshape2. So, I guess I can close this issue.