alexisvincent / systemjs-config-builder

Generate SystemJS config files from node_modules
25 stars 7 forks source link

Scoped packages are not added to config #10

Closed frederikschubert closed 7 years ago

frederikschubert commented 7 years ago

In case a package is published under a scope, it is not added to the generated config. An example for this are the Angular >= 2.0.0 packages that are published under the @angular scope. The resulting node_modules directory structure looks like this:

node_modules
├── @angular
│   ├── common
│   │   ├── README.md
│   │   ├── bundles
│   │   ├── index.d.ts
│   │   ├── index.js
│   │   ├── index.js.map
│   │   ├── index.metadata.json
│   │   ├── package.json
│   │   ├── src
│   │   └── testing
│   ├── compiler
│   │   ├── README.md
│   │   ├── bundles
│   │   ├── index.d.ts
│   │   ├── index.js
│   │   ├── index.js.map
│   │   ├── index.metadata.json
│   │   ├── package.json
│   │   ├── src
│   │   └── testing
│   ├── core
│   │   ├── README.md
│   │   ├── bundles
│   │   ├── index.d.ts
│   │   ├── index.js
│   │   ├── index.js.map
│   │   ├── index.metadata.json
│   │   ├── package.json
│   │   ├── src
│   │   └── testing
│   ├── platform-browser
│   │   ├── README.md
│   │   ├── bundles
│   │   ├── index.d.ts
│   │   ├── index.js
│   │   ├── index.js.map
│   │   ├── index.metadata.json
│   │   ├── package.json
│   │   ├── src
│   │   └── testing
│   └── platform-browser-dynamic
│       ├── README.md
│       ├── bundles
│       ├── index.d.ts
│       ├── index.js
│       ├── index.js.map
│       ├── index.metadata.json
│       ├── package.json
│       ├── src
│       └── testing
...
alexisvincent commented 7 years ago

Thanks, will look into this. Unless you want to tackle it yourself? The codebase is well documented and short. If there's anything you would like me to explain I'd be happy to add more docs. Otherwise I'll check this out myself. Just swamped with a deadline until the end of the week

frederikschubert commented 7 years ago

I can try to implement it myself. Will make a PR if I have something that's working!