search

alexisvincent / systemjs-hmr

Hot Module Replacement for SystemJS
MIT License
27 stars 11 forks source link

Use Trace.API in SystemJS 20 and SystemJS.defined in 19 (current) #6

Closed alexisvincent closed 7 years ago

alexisvincent commented 8 years ago

@guybedford

What can I rely on SystemJS.defined to provide?

alexisvincent commented 8 years ago

@guybedford ping

guybedford commented 8 years ago

@alexisvincent it is what you see :) There's no spec anywhere, just https://github.com/systemjs/systemjs/blob/master/lib/register.js#L20.

alexisvincent commented 8 years ago

@guybedford Thanks, my question was badly phrased.

In light of this issue Trace API, is it fine to use System.defined? As in this is the way you plan to move forward? :)

guybedford commented 8 years ago

It's the way to work with it in this version of systemjs. In the next major the trace api will be reliable again and defined won't be available. On Sat, 12 Nov 2016 at 11:37, Alexis Vincent notifications@github.com wrote:

@guybedford https://github.com/guybedford Thanks, my question was badly phrased.

In light of this issue Trace API https://github.com/capaj/systemjs-hot-reloader/issues/94, is it fine to use System.defined? As in this is the way you plan to move forward? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alexisvincent/systemjs-hmr/issues/6#issuecomment-260112127, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkiygxSqkETA91nnAbSpdk1FwHqMwAiks5q9Yj3gaJpZM4KqRch .

alexisvincent commented 8 years ago

Ok, thanks. Which version will it be deprecated in? 20?

guybedford commented 8 years ago

Yeah, and then replaced with the trace API from https://github.com/ModuleLoader/es-module-loader#tracing-api.

alexisvincent commented 8 years ago

Great thanks. Just to clarify. Will it be deprecated or removed in 20?

guybedford commented 8 years ago

Removed.

alexisvincent commented 7 years ago

Supported in latest build, pending https://github.com/ModuleLoader/es-module-loader/issues/532