search

alexisvincent / systemjs-hot-reloader

reloads your modules as needed so that you can have satisfyingly fast feedback loop when developing your app
MIT License
228 stars 36 forks source link

Switch to systemjs-hmr #107

Closed alexisvincent closed 8 years ago

alexisvincent commented 8 years ago

@capaj Can you review this please

peteruithoven commented 8 years ago

What kind of impact will this have on people using the systemjs-hot-reloader? Will this break the API? Will the reload and unload hooks still work? I really like the fact that this turns most of the logic into general SystemJS hooks. Turning this library into simply a connector to a SocketIO server.

alexisvincent commented 8 years ago

@peteruithuvon, yeah, so the only impact this will have is if people are using the events that systems-hot-reloader is emitting. Currently it emits the following events: change, deleted, moduleRecordNotFound, allReimported and error. The ones going away will be: moduleRecordNotFound, allReimported. If you use either of these, please let me know and we can try work around this.

But I think mostly people aren't using these events.

born2net commented 8 years ago

As far as I know the underlying API will not change. right? all remains as is as far as the interface?

alexisvincent commented 8 years ago

Other then that the API won't change for now. In the future we will be revisiting the best way to handle unload and reload events. See my thoughts here https://github.com/alexisvincent/systemjs-hmr#loader-plugin-unload-hook and here https://github.com/alexisvincent/systemjs-hmr#state-hydration-and-the-loader-plugin-reload-hook