search

alexisvincent / systemjs-hot-reloader

reloads your modules as needed so that you can have satisfyingly fast feedback loop when developing your app
MIT License
228 stars 36 forks source link

Added support for next version of systemjs-hmr #116

Closed alexisvincent closed 7 years ago

alexisvincent commented 7 years ago

@capaj Ok to merge?

jjrv commented 7 years ago

Maybe better remove yarn.lock? It's pretty big.

alexisvincent commented 7 years ago

@capaj Is it ok if I move forward and merge further pull requests myself?

capaj commented 7 years ago

@alexisvincent yarn.lock is good for apps, this is a library/utility we want to get patches from upstream dependencies. Good thing you removed it. Seems ok to merge.

alexisvincent commented 7 years ago

Technically, the yarn lock only applies to server side code. In this case, the build system. So I would argue that a yarn lock is good. But its out :)