search

alexitocr / epgp

Automatically exported from code.google.com/p/epgp
0 stars 0 forks source link

Outsiders support #237

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Support tracking epgp for people outside the guild.

Original issue reported on code.google.com by evlogimenos on 29 Nov 2008 at 2:41

GoogleCodeExporter commented 8 years ago 
Ok, i inserted it in the EPGP Version 5.4.1
So i played a bit with it and when i started a new raid with outsiders i became 
an
error message: 

Message: ..\AddOns\epgp\ui.lua line 1203:
   attempt to index local 'c' (a nil value)

Then the epgp list was a bit weird. The "outsider" had  EP/GP from another 
player and
his class color was wrong, too.
After a "reload ui" this problem was gone and all worked fine.
Every time i started a new raid the problem came back.

So i searched after it and found that in "ui.lua line 1202"

   local c = RAID_CLASS_COLORS[EPGP:GetClass(row.name)]

the function "GetClass" couldn't get back the class of the outsider.
No wonder, the class for the outsider was setted to '' in the "outsiders hack" 
cause
"UnitClass(extName)" couldn't get back a value in this state.

So i first changed:
entry.class = unitClass or ''
to:
entry.class = unitClass or class

Now if "UnitClass(extName)" fails its using the class of the placeholderalt.
This worked fine, except that the classcolor was wrong until i made a reload ui.

So i finally set "entry.seen = false" when "UnitClass(extName)" fails.
From now on the class was always correct right up from the beginning starting a 
raid
with an outsider.

This evening we have a 25 man raid and i will test it there under working 
conditions.
If this will be fine, i hope you could merge the outsider hack to your project.

__ Baaras, Pixelraiders-Blackmoore(EU)

--------------------------------------------------------------------
Attached File is the "hacked" LibGuildStorage-1.0.lua for EPGP 5.4.1
--------------------------------------------------------------------

Original comment by zaubertr...@web.de on 3 Apr 2009 at 2:54

Attachments:

GoogleCodeExporter commented 8 years ago 
So today tested in 25 man Raid and all worked fine. :-)

   --- Outsider Support is working ---

evlogimenos, could you please merge it to your project? Would be really nice.

Original comment by zaubertr...@web.de on 4 Apr 2009 at 12:16

GoogleCodeExporter commented 8 years ago 
It won't be merged now because I do not want to have to deal with it at the 
moment. This will overcomplicate 
things a lot for lootmaster/epgpweb support. After those are in I will 
reconsider it.

Original comment by evlogimenos on 4 Apr 2009 at 12:36

GoogleCodeExporter commented 8 years ago 
Hm ok.
If you allow i will try to keep track on it and hold the modified epgp updated 
here
in this thread. So those who needs outsider support could download it here 
without
playing with the lua files.

--------------------------------------------------------------------------------
                          EPGP 5.4.1 with outsider support
--------------------------------------------------------------------------------

EPGP with outsider support is for keeping track on players which are not in your
guild. So you can use it with guild alliances. 
I modificated the outsiders patch from mackatack (thx a lot) and added it into
the newest EPGP version.

--------------------------------------------------------------------------------

Usage:
"Let the outsider create an alt, invite the alt to your guild. Update the new
alt's public note to ext:NameOfOutsider, set the officer notes to 0,0 and you're
all set." (mackatack)

--------------------------------------------------------------------------------

Issues:
1. Outsiders could not see the "PR" in EPGPLootmaster window.
   (thinking about to send the PR from ML to the outsiders?)

2. Annoying creation of lvl 1 alts.

3. In EPGPweb there are the names of the alts, not of the outsiders.

--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 4 Apr 2009 at 12:36

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
--------------------------------------------------------------------------------
                          EPGP 5.4.2 with outsider support
--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 5 Apr 2009 at 12:53

Attachments:

GoogleCodeExporter commented 8 years ago 
I just noted an issue with this, this does NOT properly work with the standby 
system.
You get an error like this: 
To <XY>: XX is not eligible for EP awards

Apparently because the standby system does not scan for the ext: flag

Anyone have an idea how to fix that?

Original comment by sag.ich....@gmail.com on 12 Apr 2009 at 10:03

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Haven't tested it, but i think it will work, if you set the placeholder-twink 
of the
outsider which is in the guild on the standbylist and not the outsider himelf.

Original comment by zaubertr...@web.de on 13 Apr 2009 at 2:37

GoogleCodeExporter commented 8 years ago 
Yeah, that will most likely work, I didn't think of that. Still a rather 
annoying
workaround.

Original comment by sag.ich....@gmail.com on 13 Apr 2009 at 2:40

GoogleCodeExporter commented 8 years ago 
--------------------------------------------------------------------------------
                          EPGP 5.4.3 with outsider support
--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 16 Apr 2009 at 10:08

GoogleCodeExporter commented 8 years ago 
--------------------------------------------------------------------------------
                          EPGP 5.4.4 with outsider support
--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 17 Apr 2009 at 12:47

Attachments:

GoogleCodeExporter commented 8 years ago 
Any update for 5.4.6?

Original comment by sag.ich....@gmail.com on 24 Apr 2009 at 4:05

GoogleCodeExporter commented 8 years ago 
--------------------------------------------------------------------------------
                          EPGP 5.4.6 with outsider support
--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 24 Apr 2009 at 4:45

Attachments:

GoogleCodeExporter commented 8 years ago 
--------------------------------------------------------------------------------
                          EPGP 5.4.7 with outsider support
--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 4 May 2009 at 10:06

Attachments:

GoogleCodeExporter commented 8 years ago 
--------------------------------------------------------------------------------
                          EPGP 5.4.8 with outsider support
--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 17 May 2009 at 9:25

Attachments:

GoogleCodeExporter commented 8 years ago 
I'm wondering if anyone has considered a separate chat channel here. Basically 
ala
CTRAID back in the way back days, create a channel when the raid is joined. 
Assuming
the raid leader had state from that player before they would have a way of 
tracking
their EP/GP from previous 'groupings' with that person.

The addon could query the chat channel to get information about their priority 
rather
than the officer notes.

Original comment by cmcma...@google.com on 28 May 2009 at 8:24

GoogleCodeExporter commented 8 years ago 
--------------------------------------------------------------------------------
                          EPGP 5.4.10 with outsider support
--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 12 Jun 2009 at 12:22

Attachments:

GoogleCodeExporter commented 8 years ago 
seems to me that it doesn't work for outsiders having more alts with shared 
epgp out
of guild. For example outsider Shammy with alt Deadman which is also an outsider
creates two lvl 1 placeholders Shammmy and Deedman.

Shammmy's Note:
ext:Shammy
Shammy's Officer's Note:
2150,124

Deedman's Note:
ext:Deadman
Officer's Note:
Shammmy

This configuration caused some error when opened /epgp UI when Shammy was in 
raid and
then where should be his EP, GP and PR values there was blank space and if I 
remember
it well it was not checked for Mass awards and also it broke ordering at all.

Sorry for not bringing more specific information at the moment. I was ML of the 
raid
and we started late so I quickly switched back to original epgp addon and forgot
about it. I'll test it again soon (maybe this evening) and I'll give you more
accurate information.

Original comment by tomas.klapka on 16 Jun 2009 at 3:36

GoogleCodeExporter commented 8 years ago 
Sorry, i could not help you now changing this.
This would be a bit more of changing epgp's code and i do not want to change 
there
much until the new restructured epgp+lootmaster version is out.
And i don't have the time to have a closer look into it. (my own addon take me 
to
much time in the moment)
I only could say that you could solve this issue in only having only one lvl 1
placeholder and then always changing "ext:playername"

Original comment by zaubertr...@web.de on 20 Jun 2009 at 11:53

GoogleCodeExporter commented 8 years ago 
--------------------------------------------------------------------------------
                          EPGP 5.4.11 with outsider support
--------------------------------------------------------------------------------

Original comment by zaubertr...@web.de on 20 Jun 2009 at 11:54

Attachments:

GoogleCodeExporter commented 8 years ago 
So how does the outsider version work exactly?

We need to have those that are not part of the guild make an alt in our guild 
and
mark it a special way for it to work?

Sorry, new to this whole thing and looking for a system we can use with our 
guild,
but we have about 5 to 7 non guild members that are regular's in our raid.

Thanks!

Original comment by therig...@gmail.com on 16 Jul 2009 at 8:56

GoogleCodeExporter commented 8 years ago 
@therigwin: loot at comment 54, that's where the patch was first posted and the 
full
instructions are

Original comment by james.fi...@gmail.com on 16 Jul 2009 at 9:13

GoogleCodeExporter commented 8 years ago 
This has been working great so far for us.

When is it going to be merged back in with the main project so I can have my 
guild
officers download it from Curse.com?

Will there be an update for 5.5?

Thanks and Happy Friday!!!!

Original comment by therig...@gmail.com on 31 Jul 2009 at 6:21

GoogleCodeExporter commented 8 years ago 
Merged outsider code into 5.5.1(r1289)

Original comment by ada...@gmail.com on 3 Aug 2009 at 4:57

Attachments:

GoogleCodeExporter commented 8 years ago 
So what exactly are you merging into the new code?  Because I see 5.5.2 now 
available.

Original comment by therig...@gmail.com on 6 Aug 2009 at 4:13

GoogleCodeExporter commented 8 years ago 
Difference only in LibGuildStorage-1.0.lua. so you can easily take one from 
previous 
outsiders version and put it in new release

Original comment by ALeven...@gmail.com on 6 Aug 2009 at 9:05

GoogleCodeExporter commented 8 years ago 
Issue 506 has been merged into this issue.

Original comment by evlogimenos on 1 Sep 2009 at 11:29

GoogleCodeExporter commented 8 years ago 
Okay I have downloaded the update in comment 75. I am still confused how to 
track an 
outsider's epgp. My issue is I have someone's main in the guild but they are 
going 
to raid with us on an alt which has a different guild. How can I track his EPGP 
obtained on the unguilded alt? Like, very simply put, where do I type in the 
Outsider:Name thing? I'm not code or computer savvy so the simpler the 
instructions 
the better.

Original comment by foggyho...@gmail.com on 8 Sep 2009 at 11:19

GoogleCodeExporter commented 8 years ago 
Not "Outsider:Name"

You Type "ext:Name" (Without "" Of Course :) ) In Normal Comments.

If Name1 Has Comment ext:Name2, Then Whatever EP Or GP Name2 Gets Will Be 
Stored In
Name1's Officer Notes And Will Be Shared By Name1 And Name2.

And I Guess It Will Be Better If You Download The Latest Version:

Original comment by TheNight...@googlemail.com on 9 Sep 2009 at 1:23

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by TheNight...@googlemail.com on 25 Sep 2009 at 1:35

Attachments:

GoogleCodeExporter commented 8 years ago 
I feel like a dork, but I am not very code savvy.  To add a non-guildie to the 
EPGP 
dkpreloaded tracker, I had each of them make an alt toon named EPGPnameoftoon 
i.e.
EPGPBob is the level one of Bob.  EPGPBob is in the guild but Bob is not. Could 
you 
tell me in idiot terms how I can track Bob's EPGP?  What specifically do I type 
where (i.e. public notes, officer notes, guild information)?

Thank you so much.

Original comment by djynnhy...@gmail.com on 17 Oct 2009 at 11:45

GoogleCodeExporter commented 8 years ago 
The public note should be "ext:OutOfGuildToon" (no quotes). The officer note 
can be
blank or set to "0,0" initially, like any other main.

Original comment by krmax...@gmail.com on 22 Oct 2009 at 12:38

GoogleCodeExporter commented 8 years ago 
hello i get this error when i go with my cursor over the names in the epgp 
window
when i use epgp(outsider) with the normal one no prob

/error
Message: Interface\AddOns\epgp\ui.lua:1293: attempt to call method 'GetRank' (a 
nil
value)
Time: 10/28/09 14:43:08
Count: 11
Stack: [string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:18: in function
<[string "Interface\FrameXML\BasicControls.xml:<Scrip..."]:4>
[C]: in function `GetRank'
Interface\AddOns\epgp\ui.lua:1293: in function 
<Interface\AddOns\epgp\ui.lua:1291>

Locals: self = <unnamed> {
 cells = <table> {
 }
 check = <unnamed> {
 }
 name = "Spandj"
 0 = <userdata>
}
(*temporary) = <function> defined =[C]:-1
(*temporary) = GameTooltip {
 0 = <userdata>
 FadeOut = <function> defined @Interface\AddOns\TipTac\core.lua:818
 SetInboxItem = <function> defined =[C]:-1
 shoppingTooltips = <table> {
 }
 SetQuestLogItem = <function> defined =[C]:-1
 SetGuildBankItem = <function> defined =[C]:-1
 SetTradeTargetItem = <function> defined =[C]:-1
 SetTradePlayerItem = <function> defined =[C]:-1
 SetSendMailItem = <function> defined =[C]:-1
 updateTooltip = 0.18699999973178
 SetInventoryItem = <function> defined =[C]:-1
 comparing = false
 SetLootRollItem = <function> defined =[C]:-1
 default = 1
 Show = <function> defined @Interface\AddOns\TipTac\core.lua:808
 SetAuctionSellItem = <function> defined =[C]:-1
 SetBagItem = <function> defined =[C]:-1
 SetHyperlink = <function> defined =[C]:-1
 SetTradeSkillItem = <function> defined =[C]:-1
 SetLootItem = <function> defined =[C]:-1
 SetQuestItem = <function> defined =[C]:-1
 SetAuctionItem = <function> defined =[C]:-1
}
(*temporary) = nil
(*temporary) = <table> {
 SetNote = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:88
 CHAT_MSG_ADDON = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:142
 GUILD_ROSTER_UPDATE = <function> defined
@Interface\AddOns\epgp\LibGuildStorage-1.0.lua:165
 callbacks = <table> {
 }
 Snapshot = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:125
 PLAYER_ENTERING_WORLD = <function> defined
@Interface\AddOns\epgp\LibGuildStorage-1.0.lua:161
 RegisterCallback = <function> defined
@Interface\AddOns\epgp\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:117
 PLAYER_GUILD_UPDATE = <function> defined
@Interface\AddOns\epgp\LibGuildStorage-1.0.lua:152
 GetNote = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:83
 UnregisterCallback = <function> defined
@Interface\AddOns\epgp\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:180
 GetGuildInfo = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:115
 GetClass = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:110
 frame = LibGuildStorage-1.0_Frame {
 }
 IsCurrentState = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:119
 UnregisterAllCallbacks = <function> defined
@Interface\AddOns\epgp\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:201
}
(*temporary) = "Spandj"
(*temporary) = "attempt to call method 'GetRank' (a nil value)"
GS = <table> {
 SetNote = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:88
 CHAT_MSG_ADDON = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:142
 GUILD_ROSTER_UPDATE = <function> defined
@Interface\AddOns\epgp\LibGuildStorage-1.0.lua:165
 callbacks = <table> {
 }
 Snapshot = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:125
 PLAYER_ENTERING_WORLD = <function> defined
@Interface\AddOns\epgp\LibGuildStorage-1.0.lua:161
 RegisterCallback = <function> defined
@Interface\AddOns\epgp\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:117
 PLAYER_GUILD_UPDATE = <function> defined
@Interface\AddOns\epgp\LibGuildStorage-1.0.lua:152
 GetNote = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:83
 UnregisterCallback = <function> defined
@Interface\AddOns\epgp\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:180
 GetGuildInfo = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:115
 GetClass = <function> defined @Interface\AddOns\epgp\LibGuildStorage-1.0.lua:110
 frame = LibGuildStorage-1.0_Frame {

error\

Original comment by psych...@web.de on 28 Oct 2009 at 1:45

GoogleCodeExporter commented 8 years ago 
This was working beautifully until the last patch on November 9, 2009.  Is 
there an 
update coming up?

Original comment by mo.brow...@gmail.com on 11 Nov 2009 at 3:50

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
i have just applied the outsider patch to 5.5.10, and made some change:

1. fix the "attempt to call method 'GetRank' (a nil value)" error. Now the 
outsider's
rank will show as "Outsider(alt's name)"
2. fix a bug in outsider patch which causes performance reduction(with older 
version,
you may found a visible fps drop for every a few seconds if your guild contains 
a lot
of characters and some outsiders)
3. add support for "alt outsider", for example, for a outsider X, whose alt is 
Y( in
your guild and his officer note contains X's epgp info), now X's player wants 
to use
his another character A to play in your guild's raid without join your guild, 
and he
want to count X's and A's epgp info together. once you will need to modify Y's 
public
note every time he switches the character he uses, with this "alt outsider" 
support,
you can let the player create a new character B and join your guild, set B's 
public
note to "ext:A", and set B's officer note to "Y", then epgp will recognize X, 
A, and
B as Y's alts, now they share same epgp information and can be calculated as one
character.

Original comment by ada...@gmail.com on 21 Nov 2009 at 8:26

Attachments:

GoogleCodeExporter commented 8 years ago 
Is The Difference Between Normal And Outsider Still Only In One File?

Original comment by giorgi.m...@gmail.com on 13 Dec 2009 at 4:02

GoogleCodeExporter commented 8 years ago 
can someone hook up a new version of outsider?

Original comment by asi...@gmail.com on 20 Dec 2009 at 6:58

GoogleCodeExporter commented 8 years ago 
As There Was No Answer From "Advanced Outsider" Support Author Here Comes The 
Basic One.

Usual LibGuildStorage-1.0.lua Swap, No Additional Functions.

The Addon Itself Seems To Collide With Party Interface Causing WoW To Crash.
This Is Not Outsider Version's Fault.

Original comment by giorgi.m...@gmail.com on 8 Jan 2010 at 3:43

Attachments:

GoogleCodeExporter commented 8 years ago 
Issue 572 has been merged into this issue.

Original comment by evlogimenos on 24 Jan 2010 at 11:09

GoogleCodeExporter commented 8 years ago 
Issue 581 has been merged into this issue.

Original comment by evlogimenos on 15 Feb 2010 at 10:53

GoogleCodeExporter commented 8 years ago 
EPGP 5.5.15 With Outsider Support (.lua From 5.510)

Original comment by TheNight...@googlemail.com on 19 Mar 2010 at 7:39

Attachments:

GoogleCodeExporter commented 8 years ago 
EPGP 5.5.16 with outsider support (.lua from 5.5.10)

Original comment by TheNight...@googlemail.com on 28 Apr 2010 at 3:51

Attachments:

GoogleCodeExporter commented 8 years ago 
Would it be possible to add in some sort of 

IF (ADDON OR FILE IS PRESENT) {
USE THAT
} else {
USE EPGP DEFAULT
}

And then move this particular modified function to a separate addon library?

Original comment by matt.j.b...@googlemail.com on 27 Jul 2010 at 10:23

GoogleCodeExporter commented 8 years ago 
This is very much possible.
If you check the epgp.toc file you will find a 'debug.xml' entry on the last 
line. This file doesn't exist in the epgp repository and is created for the 
reason you described. You can make your own debug.xml file in the same folder 
as epgp.toc and add the following to your debug.xml:

<Ui xmlns="http://www.blizzard.com/wow/ui/" 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
xsi:schemaLocation="http://www.blizzard.com/wow/ui/..\FrameXML\UI.xsd">
  <Script file="my_modifications.lua"/>
</Ui>

I'll leave it to someone else to create a lua file that replaces the library 
function, but not the rest of the library.

Original comment by mackatack on 27 Jul 2010 at 10:33

GoogleCodeExporter commented 8 years ago 
Well, its been yonks since I did any sort of WoW Addon work. I'll leave it to  
TheNightCouncil since he has been so diligent in keeping this branch going.

Unless he doesn't want to.

Original comment by matt.j.b...@googlemail.com on 27 Jul 2010 at 12:15

GoogleCodeExporter commented 8 years ago 
Hello
Could someone make an update for the 5.5.19 version of EPGP please ?
Create mod that should be integrated imo, we use it for our non-guildies 
raiders.

Thx a lot

Original comment by f.gat...@gmail.com on 14 Aug 2010 at 8:09