search

alexiusacademia / electron-db

Electron module that acts as database management and uses flat file database (json file) to store tables.
MIT License
87 stars 24 forks source link

BUG - getAll example uses incorrect syntax #15

Closed Skullsneeze closed 5 years ago

Skullsneeze commented 5 years ago

I found that the example for the getAll method uses an incorrect syntax.

Current syntax:

db.getAll('customers', (succ, data)) {
  // succ - boolean, tells if the call is successful
  // data - array of objects that represents the rows.
}

Corrected syntax:

db.getAll('customers', (succ, data) => {
  // succ - boolean, tells if the call is successful
  // data - array of objects that represents the rows.
});
alexiusacademia commented 5 years ago

Thanks for pointing that out. However, this is not a bug in the code but a typo error in the example so I cannot mark it as bug.

Skullsneeze commented 5 years ago

Good point! Wasn't sure how to mark it in this case. Glad to be able to help though, and thank you for providing this awesome extension 👍

alexiusacademia commented 5 years ago

I'm glad this library helps. I am gonna be adding and updating features this coming weeks. If you have any enhancements in mind, I'm glad to know about it.Thanks!