Closed rbommel closed 3 years ago
Oh oops, I thought I was making a pull request, but I actually immediately changed the main branch. Anyway, still let me know if you agree.
@rbommel This change looks good to me, what is p in that example? We should add it as a test, and I should also fix the CI
Seven
Well now I'm super confused, did we talk about this before? I have this change locally already lol
Maybe check if you are in sync with the Github branch?
A colleague reported to me that there is a problem when computing the Tamagawa number of the following curve:
After digging into this, it seems that the problem is caused by the computation of the combinatorial automorphism group in
inertia
. I think the problem would be solved in this case by first checking for the_inertia
attribute before iterating over the full automorphism group. If you agree, I will change that. Maybe we should also print a warning if this clause is triggered.