search

alexjbest / cluster-pictures

This package implements the machinery of cluster pictures of Maistret, Morgan, Dokchitser and Dokchitser in Sage.
https://alexjbest.github.io/cluster-pictures/
GNU General Public License v2.0
3 stars 4 forks source link

just fixing a few details #46

Closed fchapoton closed 2 years ago

fchapoton commented 2 years ago

removing unused imports, some code formatting, etc

most of the change are removing white spaces at the end of lines

should not be controversial, hopefuly

rbommel commented 2 years ago

These changed all look very reasonable, I started to run the tests on them.

rbommel commented 2 years ago

One test seems to fail, but I don't think it is anything serious, but maybe @alexjbest can also take a look at it.

alexjbest commented 2 years ago

Changes don't seem to do anything objectionable, I'm guessing the test failure is some permission related problem. I've invited @fchapoton as a collaborator in case that helps, but I think I'll just merge anyways and sort it out later if the tests keep fail.

alexjbest commented 2 years ago

Indeed looks to work fine when the tests are run from master