alexjoverm / typescript-library-starter

Starter kit with zero-config for building a library in TypeScript, featuring RollupJS, Jest, Prettier, TSLint, Semantic Release, and more!
MIT License
4.37k stars 493 forks source link

Fix husky path in semantic-release-prepare script #266

Closed YannickMeeus closed 5 years ago

YannickMeeus commented 5 years ago

As of Husky 1.x, the node_modules directory structure changed somewhat. The semantic-release-prepare script did not take this into account and, as a result of this, could not run to completion.

Addresses #251

DrSensor commented 5 years ago

I've just try this patch and when committing change:

$ git commit -S

Warning: Setting pre-commit script in package.json > scripts will be deprecated
Please move it to husky.hooks in package.json, a .huskyrc file, or a husky.config.js file
Or run ./node_modules/.bin/husky-upgrade for automatic update

See https://github.com/typicode/husky for usage

husky > pre-commit (node v10.14.1)
  ↓ Stashing changes... [skipped]
    → No partially staged files found...
  ✔ Running linters...

Warning: Setting commit-msg script in package.json > scripts will be deprecated
Please move it to husky.hooks in package.json, a .huskyrc file, or a husky.config.js file
Or run ./node_modules/.bin/husky-upgrade for automatic update

See https://github.com/typicode/husky for usage

husky > commit-msg (node v10.14.1)
/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:113
        throw err;
        ^

Error: Recieved 'GIT_PARAMS' as value for -E | --env, but environment variable 'GIT_PARAMS' is not available globally
    at getEditValue (/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:239:10)
    at normalizeFlags (/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:232:15)
    at /home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:120:11
    at new Promise (<anonymous>)
    at main (/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:117:9)
    at Object.<anonymous> (/home/wildan/Projects/OSS/rollup-plugin-xs/node_modules/@commitlint/cli/lib/cli.js:109:1)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
husky > commit-msg hook failed (add --no-verify to bypass)

However, npx husky-upgrade should fix that :slightly_smiling_face: cc: @alexjoverm