search

alexjoverm / v-runtime-template

Vue component for compiling templates on the fly using a v-html like API
MIT License
605 stars 70 forks source link

Handle existing keys from mixins/plugins #21

Closed Pyro979 closed 5 years ago

Pyro979 commented 5 years ago

Added some scaffolding so that I was able to test my changes as I was developing. Feel free to grab all or just the changes in index.js and re-build on your own.

Pyro979 commented 5 years ago

@alexjoverm not sure if this reintroduces: Local state changes do not update runtime-template #1

Could you confirm? I'm not sure I understand that initial issue, and I'm I afraid that I did not cover that case.

Solinx commented 5 years ago

What is being referred to in that issue is that the dynamic component created by v-runtime copies the data properties of the parent component and does not maintain a reference, meaning that if the data in the parent component changes, the changes are not applied to the dynamic component.

Solinx commented 5 years ago

I haven't taken a close look, but I'd say your code looks good with respect to that point. This looks to be the commit where @alexjoverm made the data, etc. reactive: https://github.com/alexjoverm/v-runtime-template/commit/18069995f19a9e16a09a1a4e5a92beb984346a61

alexjoverm commented 5 years ago

Hey @Pyro979 !!! All looking good!

Thanks a lot for the PR and all the work that took!

Pyro979 commented 5 years ago

np 😄 you think it should be a minor version bump in case it causes any issues?

alexjoverm commented 5 years ago

It's a minor indeed, since it adds a new feature