resize throws error Cannot read property 'getBoundingClientRect'

alexkatz / react-tiny-popover

A simple and highly customizable popover react higher order component with no other dependencies! Typescript friendly.

MIT License

447 stars 119 forks source link

Closed ghost closed 3 years ago

ghost commented 3 years ago

Great package!

Using it quite a bit. This is to fix #100

vanluke commented 3 years ago

@daljeetv any updates on that?

ghost commented 3 years ago

just waiting to merge it

ghost commented 3 years ago

@alexkatz do you mind merging this if it looks good to you?

ilkerceng commented 3 years ago

Hi @alexkatz, i got the same error on resize. It will be really helpful to merge if PR is ok.

alexkatz commented 3 years ago

Merged check for undefined child ref before popover positioning is attempted upon window resize. Will close for now. Thanks!

fyoung-cpi commented 3 years ago

Thanks @alexkatz for merging this. Will you be publishing updated version to npm soon? Thanks again.

ptaranto commented 3 years ago

@alexkatz when the npm publish can be expected?

ilkerceng commented 3 years ago

Hi @alexkatz When i try to resize the window, i still get this error on version 6.0.6.

ilkerceng commented 3 years ago

@alexkatz I just installed 6.0.10 and it works now. Thanks.