search

alexkatz / react-tiny-popover

A simple and highly customizable popover react higher order component with no other dependencies! Typescript friendly.
MIT License
445 stars 119 forks source link

Revert "use capture for events" #172

Closed YuitoSato closed 1 year ago

YuitoSato commented 2 years ago

This reverts commit 11096b522d2fe83ba16df02ea1381a83eac91f12.

solve https://github.com/alexkatz/react-tiny-popover/issues/171

KorySchneider commented 1 year ago

Confirmed this does fix the issue.

Though, it would be better to add an option to enable this functionality (but have it off by default), as clearly it was added for a reason.

YuitoSato commented 1 year ago

@KorySchneider thank you for your replay.

Though, it would be better to add an option to enable this functionality (but have it off by default), as clearly it was added for a reason.

I can add that option in this pr. Should I wait for @alexkatz 's reply?

KorySchneider commented 1 year ago

@YuitoSato I think it making it an option would increase the chance of this PR getting merged. Don't forget to update the documentation too 🙂

@alexkatz Your input would be appreciated on what the default behavior should be!