search

alexkatz / react-tiny-popover

A simple and highly customizable popover react higher order component with no other dependencies! Typescript friendly.
MIT License
454 stars 121 forks source link

add optional "contentDestination" prop & positioning bugfix #21

Closed quantizor closed 5 years ago

quantizor commented 6 years ago

This allows for the popover contents to be rendered somewhere other than document.body.

Fixes https://github.com/alexkatz/react-tiny-popover/issues/17

quantizor commented 6 years ago 
yarn add @probablyup/react-tiny-popover

if anyone wants to try it out before merging

gaggle commented 5 years ago

Any hopes for this getting merged?

(and great library @alexkatz, thanks for making it available)

quantizor commented 5 years ago

Last commit is a bugfix - alignment is broken in the case of position right and align end in master

meikidd commented 5 years ago

Looking forward to this get merged.

Awesome library @alexkatz, and nice PR @probablyup. Thanks for doing this.

alexkatz commented 5 years ago

Thanks for this! I pulled your changes, made a few fixes, and merged! I've added this functionality to the demo, as well. Cheers!