alexkendall / react-native-bluetooth-cross-platform

Cross-Platform Bluetooth & WiFi React Native Module. Powered by underdark http://underdark.io/.
179 stars 35 forks source link

Compilation Fails for RN 48 - Execution failed for task ':react-native-bluetooth-cross-platform:compileReleaseJavaWithJavac'. #23

Open vimalathiyagu opened 6 years ago

vimalathiyagu commented 6 years ago

RN Version - 0.48.4 The android fails to run with the below error.

/node_modules/react-native-bluetooth-cross-platform/android/src/main/java/com/rctunderdark/NetworkManagerPackage.java:25: error: method does not override or implement a method from a supertype @Override ^ 1 error :react-native-bluetooth-cross-platform:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

In the NetworkManagerPackage.java : If we remove the @override from the below function it compiles. public List<Class<? extends JavaScriptModule>> createJSModules() { return Collections.emptyList(); }

bqkhiem96 commented 6 years ago

Stumbled on the same issue, @alexkendall please resolve

FlorianGerhardt commented 6 years ago

The fix was merged in #20 but probably not yet published

bqkhiem96 commented 6 years ago

How may I install via the #20 branch that you just showed? @FlorianGerhardt

FlorianGerhardt commented 6 years ago

As the branch is already in the master, you should just be able to use the repo in your package.json as shown here: https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

bqkhiem96 commented 6 years ago

I got the above problem solved by adding the dependencies as the following image Thank you @FlorianGerhardt and of course, a new wild bug appears, should I raise another issue?

FlorianGerhardt commented 6 years ago

Nice :) Should probably open a new one