using given where possible. I had to keep using implicit val and implicit def in several places because given seems to invoke the scala 3 lazy val implementation, which invokes sun.misc.unsafe, which requires extra security permissions in Elasticsearch. This is covered in https://github.com/scala/scala3/issues/9013 and it's a variant of same issue I encountered in #653
using Conversion where possible.
removed a couple minor unused/unnecessary things: a trait that we were no longer using, and a Try wrapper in several places that just ends up using .get, a type check that was getting called for every iteration of a while loop.
Related Issue
393
Changes
enumwhere possibleusingwhere possiblegivenwhere possible. I had to keep usingimplicit valandimplicit defin several places becausegivenseems to invoke the scala 3 lazy val implementation, which invokessun.misc.unsafe, which requires extra security permissions in Elasticsearch. This is covered in https://github.com/scala/scala3/issues/9013 and it's a variant of same issue I encountered in #653Conversionwhere possible.traitthat we were no longer using, and aTrywrapper in several places that just ends up using.get, a type check that was getting called for every iteration of a while loop.Testing and Validation
Standard CI and benchmarking