search

alexkramer / force-vue

Simple VueJs application which integrates with the Star Wars API (SWAPI)
http://alexckramer.com/force-vue
2 stars 21 forks source link

Added Random Planet, created a dropdown selection for all API choices #16

Closed graph1994 closed 8 years ago

graph1994 commented 8 years ago

Added a selection for all API choices, you can select a random planet and it will display its info

graph1994 commented 8 years ago

Looks like I need a way to modulate the repeated code so that I can pass this, I'll finish this tomorrow!

alexkramer commented 8 years ago

I would not worry about that code quality violation at the moment. The ideal solution would be to write a general SWAPI service which can call any of the endpoints (instead of one per endpoint). I purposefully did not write the person service to be general originally because I wanted there to be a bit more to the tasks other than simply creating views.

graph1994 commented 8 years ago

Alright So should I refactor this to make a general purpose SWAPI service, that can handle all of api calls? Am I on the right track with the drop down selection or do you want something different to change between them? I just need allite more info on all of the 'Add Support for ...' issues

alexkramer commented 8 years ago

You do not need to go ahead and create a general service (someone can take that up separately). I think the dropdown is a fine way of toggling between them for now!