search

alexkramer / force-vue

Simple VueJs application which integrates with the Star Wars API (SWAPI)
http://alexckramer.com/force-vue
2 stars 21 forks source link

Selenium test cases #22

Closed tironci closed 8 years ago

alexkramer commented 8 years ago

This project uses nightwatch js for e2e testing. Would you be able to convert your testPlanet class over to nightwatch? Then it can be easily integrated into the CI I have set up for this project. (I think there may even be a script out there that can convert the file for you). Additionally I was wondering if you could propose better identifiers for the objects you are referencing -- one small tweak to the page layout and the entire test would be broken.

tironci commented 8 years ago

Alex, I have done another pull.

alexkramer commented 8 years ago

Please remove all files except for the changes you made to add the ids to the elements as well as the nightwatch test. Also I think you need to move that file to the proper location so that it is run by the e2e command. (It doesn't look like it ran when you checked it in)