search

alexkramer / force-vue

Simple VueJs application which integrates with the Star Wars API (SWAPI)
http://alexckramer.com/force-vue
2 stars 21 forks source link

add starship and testcases #23

Closed jsnwu closed 8 years ago

jsnwu commented 8 years ago

Please review

jsnwu commented 8 years ago

@alexkramer, are you able to see my latest commit today?

alexkramer commented 8 years ago

Left a couple of code comments. Also, it looks like maybe some dependencies were left out? The dependencies in your revised test file are not being found when the tests run. (See the CircleCI build that kicked off after your last commit)

jsnwu commented 8 years ago

Fixed the typo and added back the decency file.

alexkramer commented 8 years ago

Thanks for making those changes!