search

alexkramer / force-vue

Simple VueJs application which integrates with the Star Wars API (SWAPI)
http://alexckramer.com/force-vue
2 stars 21 forks source link

Adding Film support to ForceVue #55

Closed ghost closed 7 years ago

ghost commented 8 years ago

These changes are intended to close issue #9 .

One note: I was unable to get Selenium and Nightwatch to play nicely together and therefore could not verify that the e2e tests pass. That's why I created the first commit -- I wanted to move my changes to a Linux machine and see if I could get the e2e tests to run there (I couldn't). However, the unit tests pass and I have tested the code, and it works fine as far as I can tell. Obviously I would prefer to verify the e2e tests before committing the code, but I've hit a wall on my end so I'm submitting what I have. I look forward to seeing the results of the e2e tests and making any necessary changes to get them to pass.

ghost commented 8 years ago

All of my tests seem to be passing at this point; these other errors look to me like persistent issues rather than problems with my commit. I was interested to see the e2e output on CircleCI for the Firefox tests -- that's more or less exactly the error I was getting as well.

alexkramer commented 8 years ago

You are correct @dimerization . There appears to be an issue with Firefox on the Circle CI build server. I will investigate that.