search

alexkramer / force-vue

Simple VueJs application which integrates with the Star Wars API (SWAPI)
http://alexckramer.com/force-vue
2 stars 21 forks source link

Drew's Interview #59

Closed snixer724 closed 7 years ago

snixer724 commented 7 years ago

This was a cool idea for an interview question.

Here is a change log: 1) I fixed the given E2E tests that were provided with the code. We were using the wrong selenium jar version and the wrong launch url. Also there was a note about not getting the nameTextBox to load. In the page objects we do not need the data-qa and the path down the dom (" > div > input"). You only need the data-qa. Nightwatch will find it. 2) I started to work on the unit tests but these were also broken with the provided code. I fixed the eslint errors but could not figure out why phantomJS, vue, and the module isparta were not playing nicely. 3) I wrote a unit test for ViewPlanet. 4) Added a help page and the correct route. 5) Added a privacy page and the correct route. 6) Added page-objects for the help page and privacy page. 7) Added the correct data-qa id's for each of them. 8) Wrote E2E tests to make sure that we can load the help page and privacy page correctly. 9) Wrote a missing E2E test for validating the starship records.

If you have any questions please feel free to reach out to me!

snixer724 commented 7 years ago

Great and it passed the code climate check.

alexkramer commented 7 years ago

This is great. Thanks for running down the issues with the existing tests post upgrade to Vue 2.0.