search

alexkrechik / VSCucumberAutoComplete

Cucumber (Gherkin) Full Support Extension for VSCode
https://marketplace.visualstudio.com/items?itemName=alexkrechik.cucumberautocomplete
MIT License
331 stars 82 forks source link

fix: tables formatting with CJK characters #278

Closed joeky888 closed 5 years ago

joeky888 commented 5 years ago

Table formatting is painful for CJK character users :(

Treat a CJK character with 2 spaces.

You'll need to install CJK fonts to get it work on your machine

img

joeky888 commented 5 years ago

You have to use a decent font, for example Iosevka.

Make sure 2 english letters length is equal to a CJK character on your machine.

joeky888 commented 5 years ago

Both on my browser and vscode works perfectly

img

alexkrechik commented 5 years ago

Yeah, but, ideally, it should works on all the PC's. Could we for ex. get CJK character for current font ?

alexkrechik commented 5 years ago

Font changing shouldn't destroy formatting for user.

joeky888 commented 5 years ago

No, you need to install a correct font.

This is an issue already discussed in vscode markdown addon https://github.com/yzhang-gh/vscode-markdown/issues/293#issuecomment-427635840

I am not a Chinese but they are talking about to use a correct font.

tungtrinh commented 4 years ago

This PR causes bug for all other unicode characters that been reported an issue here https://github.com/alexkrechik/VSCucumberAutoComplete/issues/328

Should be reverted.