search

alexkrechik / VSCucumberAutoComplete

Cucumber (Gherkin) Full Support Extension for VSCode
https://marketplace.visualstudio.com/items?itemName=alexkrechik.cucumberautocomplete
MIT License
331 stars 80 forks source link

Feature/GitHub issue 393 arrow functions #434

Closed Bill77 closed 2 years ago

Bill77 commented 2 years ago

This PR added launch settings for the gServer so that can be debugged via VS Code.

The primary change was to fix #393.

I changed to a more specific regex to support escape characters, also I updated the testing to ensure this works.

alexkrechik commented 2 years ago

Thank for this PR.

Bill77 commented 2 years ago

Hi @alexkrechik, any further comments, it'd be nice to get this change in, I know the change is pretty core to the product, so I can understand some hesitancy, but unless we can get more test case to cover people's exceptions, we can only go off what cases we have.

We do know it works for all cases we have today.

alexkrechik commented 2 years ago

Hi @alexkrechik, any further comments, it'd be nice to get this change in, I know the change is pretty core to the product, so I can understand some hesitancy, but unless we can get more test case to cover people's exceptions, we can only go off what cases we have.

We do know it works for all cases we have today.

Yeah, sorry for long process - I got some problems with debugging so was unable to retest. Will try again for today.

Bill77 commented 2 years ago

Hi @alexkrechik, did I miss a step post merge, to trigger the release of these changes? I noticed the market place extension hasn't updated or released.

Please let me know if there's something I needed to do to trigger the release of these changes.

Thanks in advance. 😄