search

alexkuz / flask-react-boilerplate

MIT License
368 stars 59 forks source link

Is this missing envifying process.env.NODE_ENV in production mode? #2

Closed gaearon closed 8 years ago

gaearon commented 9 years ago

React uses process.env.NODE_ENV to switch into production mode, but it seems that env variables don't include it.

Maybe it makes sense to change __CURRENT_ENV__ to be called NODE_ENV? Or else NODE_ENV to alias it.

alexkuz commented 9 years ago

@gaearon Quite possible. I would rather just leave NODE_ENV - not sure if we need these variables at all.

gaearon commented 9 years ago

+1 on leaving just NODE_ENV