alexkvak / teamcity-slack

TeamCity Slack plugin
MIT License
124 stars 23 forks source link

Don't skip unknown users, but also don't try to tag them #26

Closed mbalmes closed 6 years ago

mbalmes commented 6 years ago

{mentions} doesn't show the users if their slack name is not the same name that teamcity reports. It would be helpful if we could still see the name, but not tag them.

alexkvak commented 6 years ago

But you can see users in changes list, mentions is designed to mention slack users.

mbalmes commented 6 years ago

This may be too specific to our usage, but when we have a build fail it's very helpful to have the list of contributors visible in the slack message. We've been using a custom implementation for a while and just switched to this plugin and are missing this functionality. We've found that having the list of contributors shown in slack helps it get fixed faster, because users are less likely to do the multiple clicks to get to the changes list. I know the {changes} placeholder will list the changes with the contributor's name, but that's pretty verbose for what we need. Maybe implementing another placeholder that will tag the slack user if possible, otherwise just listing the name would work. If you agree with the need I would gladly add it myself and submit a pull request.

alexkvak commented 6 years ago

Please try newest release

mbalmes commented 6 years ago

Awesome, thanks!