alexkvak / teamcity-slack

TeamCity Slack plugin
MIT License
124 stars 23 forks source link

support icon_url field #49

Open YoungjaeKim opened 6 years ago

YoungjaeKim commented 6 years ago

First of all, thanks for the great plugin.

15 reported that icon is displayed in default bot icon, and so do I.

Even though I properly set bot profile image, Teamcity-sent message is shown in default bot icon.

Could you provide icon_url field for the message?

alexkvak commented 6 years ago

So you would like to specify icon url on global plugin settings page?

YoungjaeKim commented 6 years ago

@alexkvak thanks for the reply. Yes, correct.

I've already customized bot profile image at bot settings, but the message from this plugin only shows default bot icon.

The message from this plugin is as below; image

But when I click the profile, the bot profile image is already defined as below; image

So, I thought that this issue could be resolved by the plugin global settings page, and the plugin consumes it by using icon_url Slack api field.

alexkvak commented 6 years ago

Could you try to change Slack TeamCity user's icon?

YoungjaeKim commented 6 years ago

I'm sorry it's quite confused; what is Slack TeamCity user icon? There's no TeamCity user account actually, as this account is created by adding bot app.

I've tried two bot apps. both are providing API Token.

  1. Bots; https://clova.slack.com/apps/A0F7YS25R-bots?next_id=0
  2. Hubot; https://clova.slack.com/apps/A0F7XDU93-hubot

Note that my organization restricts bot apps and Hubot is the only one that I can use now.

alexkvak commented 6 years ago

Note that my organization restricts bot apps and Hubot is the only one that I can use now. Probably this is the reason you don't have an icon from app?

Please also check whether your app is added to the channel.

YoungjaeKim commented 6 years ago

@alexkvak Yes, the bot is added to channels. That's why the bot can send messages to the channel by your plugin :) The bot configuration page shows its invited channels and I confirmed that it seems OK.

image

alexkvak commented 6 years ago

default this is how the bot is added to my slack. Please compare to your settings

YoungjaeKim commented 6 years ago

@alexkvak I found that your bot settings page and mine look slightly different. Mine is as below;

image

According to document Authorship section, I think the bot we are saying could be different type; Slack App user token, and Slack App bot user token? Or, mine is probably a workspace app.

Whatever it is, it seems they could work differently. (I don't believe the document freshness, but we can check that there can be differences between two).

I assume that icon_url on each message could resolve the profile photo issue as this field will guarantee an icon for the one message.

LazyTarget commented 5 years ago

@alexkvak I also am in need for this feature. My Slack configuration looks like @YoungjaeKim except instead of "Hubot" it simply says "Bots". With the url: https://{TEAM}.slack.com/apps/A0F7YS25R-bots

I believe, as @YoungjaeKim originally mentioned that the icon_url field needs to be set, using a global configuration for the Slack plugin (as like with the SenderName)

Could you provide icon_url field for the message?

I'd be happy to implement this although.. my knowledge of scala is basically zero