search

alexkvak / teamcity-slack

TeamCity Slack plugin
MIT License
124 stars 23 forks source link

Memory leak detected by Eclipse Memory Analyzer #59

Closed testworksau closed 3 years ago

testworksau commented 5 years ago

Firstly, thanks for the plugin, it works well!

Our TeamCity server ran out of memory a couple of times in the past month or so. The last time this happened, we took a memory dump from the TeamCity administration interface to find out why.

The results of the dump file analysis are shown in the image below - it looks like the web socket sessions from simpleslackapi are not getting cleaned up.

We are using version 1.1.8 of this plugin, with TeamCity 2018.1.3

image

This problem may be related to this issue, which was fixed in simple slack api release 1.2.0

https://github.com/Ullink/simple-slack-api/issues/180

alexkvak commented 5 years ago

@testworksau thank you too, good catch! Would you like to make a PR? 🙂

alexkvak commented 5 years ago

@testworksau I've updated simple-slack-api up to 1.2.0, but now it hang while creating connection session. I cannot find respective issue in its repo, could you?

testworksau commented 5 years ago

@alexkvak sorry for the delay getting back to you. I found this - I'm not sure if it's relevant.

https://github.com/Ullink/simple-slack-api/issues/174

alexkvak commented 3 years ago

Itiviti/simple-slack-api was removed in 2.0.0