search

alexkvak / teamcity-slack

TeamCity Slack plugin
MIT License
124 stars 23 forks source link

Plugin fails after TeamCity 2019.1.3 upgrade. #73

Closed AlkisFortuneFish closed 4 years ago

AlkisFortuneFish commented 4 years ago

After upgrading to TeamCity 2019.1.3, the plugin has stopped working. The log contains the attached callstack. TC.log

alexkvak commented 4 years ago

What plugin version do you have?

AlkisFortuneFish commented 4 years ago

According to the version displayed on the Plugin List, 1.2.0.

alexkvak commented 4 years ago

It seems that your data/config/slackIntegration.json contains incorrect characters. Please see #17 while I upgrade my TC.

AlkisFortuneFish commented 4 years ago

Yep, that's right. The message templates contained emojis. Removing them from the json config fixes the issue but of course leaves us with the problem that otherwise perfectly valid templates containing Unicode do not work.

alexkvak commented 4 years ago

Is the emoji stored as bytes sequence (e.g. \xF0\x9F\x98\x81) or not?

AlkisFortuneFish commented 4 years ago

They are not. They are stored as unescaped UTF-8 in the json. They were inserted using the UI. Interestingly, the previous version of TC we were using (~19.1.1, I think~ actually 19.1.0) had no problem with that.

alexkvak commented 4 years ago

@AlkisFortuneFish please try release 1.3.0 https://github.com/alexkvak/teamcity-slack/releases/tag/v1.3.0 Feel free to re-open if issue is still reproduces

AlkisFortuneFish commented 4 years ago

It works, thanks for the fix. One thing, the version didn't actually get bumped, release 1.3.0 is still 1.2.0 in teamcity-plugin.xml.

alexkvak commented 4 years ago

@AlkisFortuneFish thanks! Release was re-published