search

alexkvak / teamcity-slack

TeamCity Slack plugin
MIT License
124 stars 23 forks source link

Missing bot user image in Slack #95

Closed IanLeeClaxton closed 4 years ago

IanLeeClaxton commented 4 years ago

Having an option for setting SlackChatConfiguration.getConfiguration.asUser() when there is no username specified solves a number of issues. Using the default username TeamCity is fine if you have a user named teamcity or have some legacy config but for new configurations this is not working.

Without this we are stuck in limbo where we are unable to use the new bot scopes with the plugin and only able to use legacy bots which unless asUser() is set has the default slack grey bot icon (which sucks).

I had to comment out three failing tests as my understanding of scala is limited and I don't know if the failures are just due to my environment.

Happy to fix just let me know.

alexkvak commented 4 years ago

All commented tests passes. What failures you have?

alexkvak commented 4 years ago

Could you revert pom.xml and slackIntegration-server/src/test/scala/com/fpd/teamcity/slack/MessageBuilderTest.scala and then squash all commits?

I'll merge this PR and bump the version.

IanLeeClaxton commented 4 years ago

Hi @alexkvak, sorry for the delay.

I have reverted and squashed.

Ian