search

alexkychen / assignPOP

Population Assignment using Genetic, Non-genetic or Integrated Data in a Machine-learning Framework. Methods in Ecology and Evolution. 2018;9:439–446.
http://alexkychen.github.io/assignPOP/
GNU General Public License v3.0
17 stars 4 forks source link

Tests expectation with ggplot2 3.5.0 #25

Closed teunbrand closed 3 months ago

teunbrand commented 5 months ago

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break assignPOP.

This PR updates a few tests in assignPOP to deal with the latest changes. In summary, the str(plot) object can change when ggplot2 changes its internals, making these tests fragile. These tests have been replaced to expect a ggplot object.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of Februari. The progress of the release can be tracked in https://github.com/tidyverse/ggplot2/issues/5588. We hope that this PR might help assignPOP get out a fix if necessary.

teunbrand commented 4 months ago

This is just a kind reminder that we plan to release ggplot 3.5.0 soon.