Open markisadesignerd opened 3 years ago
Thanks for raising the issue!
I'm happy to accept a PR that introduces a fix for this based on ember-compatibility-helpers
, as long as we can add Ember 3.12
to our ember-try
configuration to ensure that things continue to work on that version, and the modern ones!
That would mean
ember-3.12
similar to this oneOh, came here for this - the README says compat with 3.12 - but I think 3.15 might be more accurate (since the package.json says ember octane)
Yeah, the README is definitely wrong here.
I'm happy to just update the README to reflect the correct version (it's a shame that the Ember CLI generates a README by default with such an old supported version; it should really default to the oldest LTS that the ember-try
configuration generated at creation time supports) but if we can actually get Ember 3.12 working instead, that would be good with me, too!
As it turns out, my solution didn't properly handle the tracked value, so initial values were fine but updates to the provider wouldn't propagate. Pre-Octane Ember isn't exactly my specialty, though. Might just be easier to set the dependency to >=3.13 for now?
I'm working in a legacy app currently locked to 3.12.4 and when trying to use the component I receive the following error:
I scaffolded a new app with
ember-source
at 3.12.4 with the same result.When looking at this line, it seems like in versions below 3.13
capabilities
might be undefined? By comparison,@glimmer/component
seems to handle it using theember-compatibility-helpers
like this.I have a fork that implements
capabilities
this way and it seems to work, but I'm unaware if there are any incompatibilities or side effects (I'm relatively new to the inner workings and deprecations of Ember).