search

alexlafroscia / ember-react-components

Render React components in Ember
https://alexlafroscia.github.io/ember-react-components
MIT License
52 stars 16 forks source link

outputFile and lazy loading react/react-dom #33

Open jbailey4 opened 5 years ago

jbailey4 commented 5 years ago

This is a great addon and the use of a decorator to add React support within Ember is a nice solution.

Everything is working great at runtime, however, using the outputFile config option to lazy load react/react-dom is not actually splitting out the dependencies in a separate file.

I also tried to just use dynamic imports to load react and react-dom, since the app I work on also has ember-auto-import, but this doesn't work either.

It seems like react and react-dom always get added to the consuming app's vendor.js.

VincentMolinie commented 3 years ago

I do have the same issue 🤔