Closed poteto closed 5 years ago
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.
Latest deployment for this branch: https://use-task-git-fork-poteto-lt-update-tsconfigs.alexlafroscia.now.sh
Previously, the docs site was getting the useTask
type definition from the Pika output. Is this a different, more elegant means to the same end?
Before this change, you'd have to build first before it can locate types:
Fresh install:
After yarn build
:
I don't think it's particularly ergonomic to have to run yarn build
(granted, you probably wouldn't be doing it that often, but it'd be easy to forget) when you want to make changes to the docs. The advantage of this change is that it works "out of the box". The sort-of-downside is that the type definitions are tied to src
and not the version that was listed in docs/package.json
Makes sense to me! I want to remove the resolutions in the root level package.json
that point into the pkg
directory then — that shouldn’t be necessary with this change. I’ll add a commit to the PR to handle that.
use-task