search

alexlee188 / ghpsdr3-alex

Modifications of John Melton's ghpsdr3
GNU General Public License v3.0
64 stars 38 forks source link

Build fails with new ortp version #24

Closed stoecker closed 10 years ago

stoecker commented 10 years ago

A patch to fix this issue is here, thought it will break old version.

https://build.opensuse.org/package/view_file/home:dstoecker/ghpsdr3-alex/ghpsdr3-alex_ortp_update.diff?expand=1

As this patch works for openSUSE I'm happy with it. To properly support it in the code, and #ifdef would be needed and an check for the function call in the configure step.

stoecker commented 10 years ago

Source for the patch: https://groups.google.com/forum/#!msg/sdr-widget/u14nzcuTNyU/wdTMyqbBcCsJ

alexlee188 commented 10 years ago

HI Stoecker,

Thanks for the previous pull request which I have merged into master.

As for the ortp issue, our plan is to wait for Ubuntu to upgrade the ortp version, and at that time, the ortp patch can be applied so that it builds with on both Ubuntu and OpenSUSE.

We will retain the old ortp version for now as most developers are using Ubuntu.

However, if you can update the configuration scripts to test for BOTH ortp versions and put in conditional compiles I will be very happy :-)

Let me know your github id so that I can add you to the developers' list.

Alex

On Fri, Jan 31, 2014 at 3:02 PM, stoecker notifications@github.com wrote:

A patch to fix this issue is here, thought it will break old version.

https://build.opensuse.org/package/view_file/home:dstoecker/ghpsdr3-alex/ghpsdr3-alex_ortp_update.diff?expand=1

As this patch works for openSUSE I'm happy with it. To properly support it in the code, and #ifdef would be needed and an check for the function call in the configure step.

Reply to this email directly or view it on GitHubhttps://github.com/alexlee188/ghpsdr3-alex/issues/24 .

stoecker commented 10 years ago

Patch see #25.

alexlee188 commented 10 years ago

Working in Ubuntu, and merged. Thanks.

On Sat, Feb 1, 2014 at 8:45 PM, stoecker notifications@github.com wrote:

Closed #24 https://github.com/alexlee188/ghpsdr3-alex/issues/24.

Reply to this email directly or view it on GitHubhttps://github.com/alexlee188/ghpsdr3-alex/issues/24 .