FCNN layers missing labels

alexlenail / NN-SVG

Publication-ready NN-architecture schematics.

http://alexlenail.me/NN-SVG/

MIT License

4.49k stars 579 forks source link

FCNN layers missing labels #14

Closed eshrh closed 5 years ago

eshrh commented 5 years ago

Hey! I really liked using this tool as a very simple visualization for models, but there might be a bug in the FCNN style.

Adding a extra node at the end of the model leads to a missing Output Layer label. Similarly, adding an extra node after that one leads to both nodes missing their labels. Here's what I mean

I would have loved to try to PR and solve it myself, but I'm not too comfortable with JS, so I think I'm out of my league a little here!

alexlenail commented 5 years ago

Thanks for the bug report, @eshanrh ! I added the labels at the very end so they're liable to have a few bugs. I'll look into it!

eshrh commented 5 years ago

That's totally fine, I ended up hiding labels and then adding them myself which wasn't hard at all, but I thought it might be nice to have it working for everyone else!

alexlenail commented 5 years ago

@eshanrh would you check for me that this is fixed now (check http://alexlenail.me/NN-SVG/ and make sure to refresh the cache / visit it in incognito)?

If it isn't fixed, I'd much appreciate some repro steps =)

eshrh commented 5 years ago

Works perfectly!