search

alexlenail / NN-SVG

Publication-ready NN-architecture schematics.
http://alexlenail.me/NN-SVG/
MIT License
4.49k stars 579 forks source link

Download SVG button not working on Safari 12.0.2 #17

Closed captainvera closed 5 years ago

captainvera commented 5 years ago

Hey,

I was experimenting around with NN-SVG and I discovered that the 'Download SVG' functionality does not work on safari 12.0.2

It seems to be browser specific as it works as expected on Chrome

alexlenail commented 5 years ago

@captainvera thanks for reporting. What kind of error message do you get? Or how does it fail?

captainvera commented 5 years ago

On the visual side, nothing happens, it just fails.

But this error pops-up in the JS console: screenshot

Not sure why it only happens on safari (edit: this doesn't show up in chrome, I tested)

alexlenail commented 5 years ago

@captainvera I couldn't reproduce this on firefox, chrome, or safari on my machine -- but the error gives a hint that your browsers don't like my google analytics (I wanted to count downloads).

I've turned off google analytics for the download. Can you see if it works now?

(perhaps you have an anti-google analytics chrome extension? )

captainvera commented 5 years ago

@zfrenchee It is working correctly now!

I have Ublock Origin 1.16 installed, maybe it was that? Maybe you could catch the analytics error and continue gracefully if people have an adblocker?