search

alexlenail / NN-SVG

Publication-ready NN-architecture schematics.
http://alexlenail.me/NN-SVG/
MIT License
4.49k stars 579 forks source link

Height and width confusion in show dimensions text using AlexNet webGL #52

Open sumeyye-agac opened 1 year ago

sumeyye-agac commented 1 year ago

Tensor width and height order seems to to be incorrect. (For filter size dimensions, it is not wrong)

Screen Shot 2023-01-14 at 23 24 59
alexlenail commented 1 year ago

@sumeyye-agac thanks for reporting this. Would changing the order of the help text (right underneath the word architecture be enough to fix this?

jpauwels commented 6 months ago

Hi @alexlenail. The text underneath "Architecture" is correct, as you can see that a height of 50 and a width of 500 gives rectangles that are wider than they are tall, but the labels are simply misplaced. The 50 label should be put on the height, not the width. Fixed in PR #60.