Open tirtho109 opened 4 months ago
Hi @tirtho109 The layer dimension should be dependent on whether the user selects the "show bias units" checkbox. If I'm reading correctly, your PR always decrements the layer width by 1, but we shouldn't assume there's a bias unit unless the user presses the checkbox.
Hi @alexlenail, Thanks for the feedback! Can you check one more time?
Why do you need a new state variable wasBiasShown
when you already have showBias
?
Bias shouldn't be counted as layer dimension. So the dimension in the input and hidden layer needs to be reduced by 1 for FCNN.js