nus-pe-bot
commented
4 years ago Team's Response
Hi, thank you for pointing out the first error, the activation bar should indeed be extended to include the List all contacts function.
For the second error pointed out, CommandHandler object would be destroyed right after executing ListMsgUI() and thus, i feel that it is okay to put it at the end. It shouldn't be a return arrow since ListMsgUI() is a function call.
For the third error pointed out, the returned contact list is indeed being shown to the user in the CLI and thus, it skips past multiple activation bars to the user. I think that it would be okay to do so as long as it follows the rules of sequence UML and our implementation reflects that.
Items for the Tester to Verify
:question: Issue severity
Team chose [severity.VeryLow]
Originally [severity.Medium]
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
The first arrow list all contacts is not pointing to an activation bar. Perhaps you can extend the activation bar for LogicManager.
A solid arrow is draw at the end of the activation bar for CommandHandler. However, it is not possible to call any methods at the end of the activation bar. Instead, it should be a return arrow. Perhaps you should extend the activation bar for CommandHandler.
Also the return arrow of Display Contact List skips past multiple activation bars. Instead, the return arrow should stop at the previous activation bar.