[Bug] `dirvish-use-header-line nil` also hides a user defined headerline

[JordanAnthonyKing]

Thank you for the bug report

• [X] I am using the latest version of dirvish related packages.
• [X] I checked CUSTOMIZING|EXTENSIONS.
• [ ] You may also try reproduce the issue using clean environment and minimal configurations with the command emacs -Q.

Bug description

If using your own headerline, dirvish will replace it. Setting dirvish-use-header-line nil will hide it completely.

Is there a workaround?

Steps to reproduce

Define a headerline, and open dirvish. Depending on dirvish-use-header-line there will either be no headerline, or the dirvish one. No third option for 'keep own'.

Expected behavior

Don't overwrite or provide an option to not overwrite.

OS

Windows

Emacs Version

gccemacs-29

Emacs Configurations

Nano

Error callstack

No response

Anything else

No response

[alexluigit]

Hi @JordanAnthonyKing , thanks for your report. dirvish-use-header-line will hide the header line anyway (regardless your dirvish-header-line-format config).

If using your own headerline, dirvish will replace it. Setting dirvish-use-header-line nil will hide it completely.

What do you mean by "replace it"? If you want the header line, why not just keep it as t and only customize the dirvish-header-line-format option?

(setq dirvish-header-line-format '(:left (path) :right (free-space)))