alexluigit / dirvish

A polished Dired with batteries included.
GNU General Public License v3.0
795 stars 44 forks source link

[Bug] Wrong vc-state for untracked files #224

Open schrenker opened 1 year ago

schrenker commented 1 year ago

Thank you for the bug report

Bug description

Hello,

I have strange issue, with vc-state used in dirvish. Let me use my emacs.d as an example. This is what I see in dirvish: image These are my faces: image image

I am setting these faces in there: https://github.com/schrenker/emacs.d/blob/master/init.el#L1415C9-L1415C9

My git ignore and magit for the directory: image

My Elisp-fu and emacs knowledge is still not where I wish they were. I cannot wrap my head around why some ignored, or up to date files have 'edited' state next to them, some have up-to-date state, and some don't have any state at all, even though there should be only two: up-to-date and none(ignore). I would appreciate the help.

Steps to reproduce

Set face colors for all vc-states, open up dirvish in any git managed directory.

Expected behavior

Correct colors of vc state based on actual state.

OS

MacOS

Emacs Version

gccemacs-29

Emacs Configurations

Vanilla emacs + emacs plus

Error callstack

No response

Anything else

No response

fountainer commented 1 year ago

I have the same issue.

uqix commented 7 months ago

Same issue, edited state (vc-edited-state face) is applied for ignored dirs.