Dirvish header and mode lines not displayed when using Emacs 30

nloyola commented 4 months ago

Thank you for the bug report

[X] I am using the latest version of dirvish related packages.
[X] I checked CUSTOMIZING|EXTENSIONS.
[ ] You may also try reproduce the issue using clean environment and minimal configurations with the command emacs -Q.

Bug description

I compiled Emacs from the main branch of the Git repository today. When using dirvish, the header and mode lines do not display anything. If I go back to Emacs 29.x, I see the mode and header lines normally, having the same package installed in both situations.

Here are the details from report-emacs-bug:

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.16.0) of 2024-03-07 built on asterix
Repository revision: 8aabd835747297818d538cc16b3f53fcc1dd67f6
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux 12 (bookworm)

Steps to reproduce

I built Emacs from this commit hash 8aabd835747297818d538cc16b3f53fcc1dd67f6.

Expected behavior

Mode and header lines should appear.

OS

Linux

Emacs Version

27

Emacs Configurations

No response

Error callstack

No response

Anything else

No response

deadcombo commented 3 months ago

I can replicate this.

A lot of void-variable dv messages streaming through, might be related.

Error during redisplay: (eval (dirvish-index-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-path-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-sort-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-symlink-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-omit-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-yank-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-index-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-path-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-sort-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-symlink-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-omit-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-yank-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-index-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-path-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-sort-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-symlink-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-omit-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-yank-ml dv) t) signaled (void-variable dv)
Error during redisplay: (eval (dirvish-index-ml dv) t) signaled (void-variable dv)

ST-Saint commented 2 months ago

confirmed with emacs -Q

version: GNU Emacs 30.0.50 Development version 0fab2649e288 on master branch; build date 2024-04-12.

alexluigit / dirvish