Dollar sign in root reducer and master middleware when generating cycle

[paulmoliva]

Generated a cycle just now and here is what I got in root reducer and master middleware.

import { combineReducers } from 'redux';
  import CarsReducer from './cars_reducer';

const RootReducer = combineReducers({

$     cars: CarsReducer
});

export default RootReducer;

import { applyMiddleware } from 'redux';
  import CarsMiddleware from './cars_middleware';

const masterMiddleware = applyMiddleware(

$     CarsMiddleware
);

export default masterMiddleware;

Could be an easy fix? @JescaLyn

[JescaLyn]

​Yeah I think this issue is because of the difference between GNU sed editor and Mac sed editor. GNU can handle tab literals, but Mac needs it to be wrapped in a $'' ASCII quote tag.​ This might just need to be handled with if/else logic about the kind of sed editor. I'll look into how to determine which sed editor the user has

On Mon, Sep 26, 2016 at 12:28 PM, Paul Oliva notifications@github.com wrote:

Generated a cycle just now and here is what I got in root reducer and master middleware.

import { combineReducers } from 'redux'; import CarsReducer from './cars_reducer'; const RootReducer = combineReducers({

$ cars: CarsReducer }); export default RootReducer;

import { applyMiddleware } from 'redux'; import CarsMiddleware from './cars_middleware'; const masterMiddleware = applyMiddleware(

$ CarsMiddleware ); export default masterMiddleware;

Could be an easy fix? @JescaLyn https://github.com/JescaLyn

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/amattson21/eos-redux/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AS_oB1CzMr0wIWiO85XjFDMh6uZiySagks5quBzBgaJpZM4KG5wp .

[paulmoliva]

Resolved by #22