search

alexmchale / xmlstats-ruby

A ruby client for xmlstats, an easy to use API for obtaining MLB and NBA statistics in XML or JSON.
MIT License
5 stars 2 forks source link

Mlb roster #4

Closed RinkeRiezebos closed 9 years ago

RinkeRiezebos commented 9 years ago

I Alex,

I added the mlb_roster method. Could you please test it (if you want - it works for me) and pull it? Please see my notes and the issue I filed: https://erikberg.com/api/issues/197. Let me know how you want to deal with it.

Cheers! Rinke

alexmchale commented 9 years ago

I'm sorry this took me so long to get to. Thank you for submitting this. I've merged these changes.

RinkeRiezebos commented 9 years ago

awesome, no problem. Thanks for merging.

On 12 April 2015 at 13:55, Alex McHale notifications@github.com wrote:

I'm sorry this took me so long to get to. Thank you for submitting this. I've merged these changes.

— Reply to this email directly or view it on GitHub https://github.com/alexmchale/xmlstats-ruby/pull/4#issuecomment-92046494 .

alexmchale commented 9 years ago

Version 1.7.0 includes this feature. Thank you!

RinkeRiezebos commented 9 years ago

:)

On 13 April 2015 at 15:40, Alex McHale notifications@github.com wrote:

Version 1.7.0 includes this feature. Thank you!

— Reply to this email directly or view it on GitHub https://github.com/alexmchale/xmlstats-ruby/pull/4#issuecomment-92356133 .