search

alexmercerind / flutter_acrylic

Flutter library for window acrylic, mica & transparency effects.
MIT License
595 stars 53 forks source link

Fix Windows 11 Acrylic effect Title Bar bug #81

Closed Auties00 closed 2 months ago

Auties00 commented 1 year ago

After setting the acrylic effect on Windows 11 with the following code:

    await Window.setEffect(
      effect: WindowEffect.acrylic,
      color: Colors.transparent,
      dark: true
    );

Currently, the Window looks like this when focused: Screenshot (24)

With my fix, it looks like this: Screenshot (23)

This behaviour is coherent with the native behaviour, for example in the Settings app: Screenshot (25)

I also created an enum for the DWMWINDOWATTRIBUTE values that the library needs.

Adrian-Samoticha commented 1 year ago

@alexmercerind Can you test this PR on your machine? I don’t have access to a Windows 11 machine.

Auties00 commented 4 months ago

Any chance this could be merged?

Adrian-Samoticha commented 3 months ago

Alright, it seems that @alexmercerind isn’t really active these days (at least on this project), so maybe I’ll just merge and publish it anyway. @Auties00, have you checked that your fix doesn’t introduce any regressions on Windows 10?

Auties00 commented 3 months ago

Alright, it seems that @alexmercerind isn’t really active these days (at least on this project), so maybe I’ll just merge and publish it anyway. @Auties00, have you checked that your fix doesn’t introduce any regressions on Windows 10?

I've checked that and it doesn't cause any issues, yet I've noticed yesterday that if you have a WinSDK that defines the enumeration i added it will go in conflict. I'll push a fix for that

NextdoorPsycho commented 3 months ago

Alright, it seems that @alexmercerind isn’t really active these days (at least on this project), so maybe I’ll just merge and publish it anyway. @Auties00, have you checked that your fix doesn’t introduce any regressions on Windows 10?

I've checked that and it doesn't cause any issues, yet I've noticed yesterday that if you have a WinSDK that defines the enumeration i added it will go in conflict. I'll push a fix for that

ive tested and it works for me, not that a random on the internet can be any justification for merging it. but its a +1 from me