search

alexmihai / marketbilling

Automatically exported from code.google.com/p/marketbilling
0 stars 0 forks source link

Patch for /v3/src/com/example/android/trivialdrivesample/util/IabHelper.java #176

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Fixed querySkuDetails issue: won't query anything if skuList.size % 20 == 0.

Original issue reported on code.google.com by luteni...@gmail.com on 23 Jan 2014 at 8:46

Attachments:

GoogleCodeExporter commented 8 years ago 
Didn't meant to create a new issue.
This is the error on issue 123 fix: 
https://code.google.com/p/marketbilling/issues/detail?id=123#makechanges

Original comment by luteni...@gmail.com on 23 Jan 2014 at 8:51

GoogleCodeExporter commented 8 years ago 
Hey lutenidze, I think Google merged the patch by Valerio Santinelli wrong 
because they did it by hand long after the patch was compatible with the 
original source.

I applied it to that source code revision and it seems that they put an ending 
curling brace for an if statement wrong - see my attachment. Therefore your new 
patch isn't needed, right?

Or are you saying that the original patch by Valerio Santinelli was wrong as 
well?

Original comment by marko.st...@outfit7.com on 5 Feb 2014 at 12:41

Attachments:

GoogleCodeExporter commented 8 years ago 
@marko you are right. Trevor, the guy who merged my patch, did it wrong. 

I've posted the correct code taking the head of the repo as of today here: 
https://code.google.com/p/marketbilling/issues/detail?id=123#c18

Original comment by santine...@gmail.com on 5 Feb 2014 at 2:31

GoogleCodeExporter commented 8 years ago 
@marko yes, they merged the patch by Valerio Santinelli wrong. I suggested how 
to fix the merge, sorry for not clarifying that.

Original comment by luteni...@gmail.com on 6 Feb 2014 at 6:02

GoogleCodeExporter commented 8 years ago 
Thanks for your 2 quick replies, guys!

Original comment by marko.st...@outfit7.com on 6 Feb 2014 at 3:18