search

alexmilowski / green-turtle

An RDFa 1.1. implementation for browsers.
MIT License
56 stars 20 forks source link

Node.js support, baseURI fix #8

Closed bergos closed 8 years ago

bergos commented 8 years ago
elf-pavlik commented 8 years ago

I guess it solves #3 @davidlehn after this merge you could most likely add green-turtle as dependency to jsonld-request instead keeping modified copy https://github.com/digitalbazaar/jsonld-request/blob/master/lib/rdfa.js

elf-pavlik commented 8 years ago

@sballesteros do you think green-turtle can pull in something from https://github.com/scienceai/graph-rdfa-processor ?

sballesteros commented 8 years ago

@elf-pavlik absolutely! Ideally green-turtle could directly require / import graph-rdfa-processor. graph-rdfa-processor could also export most of the sub classes it needs that are also used by green-turtle.

Some more context: I pinged @alexmilowski when I did that but I guess he was too busy at the time. The reason I started that was precisely to be able to replace https://github.com/digitalbazaar/jsonld-request/blob/master/lib/rdfa.js in the jsonld.js library like you mention in https://github.com/alexmilowski/green-turtle/pull/8#issuecomment-210687569 (https://www.npmjs.com/package/node-green-turtle does not include enough of the green-turtle code base to achieve that, and I also wanted to have a library easy to consume from node.js / browserify (so not ant / Java build step etc.) and following more idiomatic error reporting (using Error instead of plain strings). I mostly use graph-rdfa-processor for that purpose see for instance https://github.com/scienceai/jsonld-rdfa-parser. I need to send some PR to the json-ld.js lib but have been super busy working on https://science.ai. If there is interest I would love to help making that happen!

elf-pavlik commented 8 years ago

@alexmilowski replied to my email few days ago that now he will have time for improving green-turtle and take a look at this PR :tada:

I would like to invite both of you to consider coordinating efforts with participants of RDFJS CG

Which already provides online ground where people working on rdf-ext, rdflib.js, jsonld.js, N3.js etc. start coordinating efforts! :boom:

alexmilowski commented 8 years ago

Hello all,

Looks good. Sorry it took me so long to get to this.