search

alexmingoia / purescript-pux

Build type-safe web apps with PureScript.
https://www.purescript-pux.org
Other
566 stars 76 forks source link

Upgrade to smolder 9 #125

Closed MichaelXavier closed 7 years ago

MichaelXavier commented 7 years ago

From smolder 7 to 9, it looks like the second argument for the Element constructor went from (Maybe (Markup e)) to (Markup e). I'm attempting to get pux back into the psc-package package set which recently upgraded to smolder 9, so this is necessary.

alexmingoia commented 7 years ago

Oh man! I just pushed this same update. I'm reading about package sets now... I guess I missed that memo?

MichaelXavier commented 7 years ago

Haha! Odd timing. I'll close this then. Package-sets doesn't seem to have guidelines as to who submits projects for inclusion, and since I know not everyone is onboard yet, I'm basically adding my project dependencies and then submitting those as PRs. You don't have to be concerned about package sets unless you want to be, but its a set of packages and a listing of their dependencies frozen at a specific release. So it encourages sort of a lockstep upgrade process kind of how stack works.