search

alexmingoia / purescript-pux

Build type-safe web apps with PureScript.
https://www.purescript-pux.org
Other
566 stars 76 forks source link

updates dependencies and code to be compatible with purs 0.12 #158

Closed roryc89 closed 6 years ago

roryc89 commented 6 years ago

Updates dependencies and code to be compatible with purs 0.12. #157

I am relatively new to Purescript and totally new to Pux so sorry if there are mistakes. I'm especially not sure if the unsafePerformEffect in src/Pux/DOM/History.purs is ok.

megamaddu commented 6 years ago

Nice, looks really close at least! Updating the examples to see if the tests pass will probably answer your unsafePerformEffect question.

roryc89 commented 6 years ago

Thanks @spicydonuts. Updating the examples now.

roryc89 commented 6 years ago

Examples are building except for the react-interop example, which has a missing MissingFFIModule error The foreign module implementation for module ReactInteropExample.ReactComponent is missing..

I wasn't aware of purs 0.12 changes that would effect this behaviour so just wanted to check that this was building successfully previously and that I wasn't missing a build step.

alexmingoia commented 6 years ago

Thank you for updating this.