search

alexmingoia / pux-starter-app

Starter Pux app w/ hot-reloading and isomorphic routing and rendering
https://www.purescript-pux.org
BSD 3-Clause "New" or "Revised" License
101 stars 39 forks source link

Moves src/purs/ files up a level to src/ #10

Closed damncabbage closed 8 years ago

damncabbage commented 8 years ago

I'm aware this is likely a controversial change. I'm proposing the src/purs/*.purs files be moved up a directory, to src/*.purs, and src/html and src/js be moved up to their own top-level directories (html and support respectively).

Why? To aid in being able to rely on defaults for, say, IDE integration, or other tooling that relies on finding things (by default) in certain spots. There's a much longer discussion in this Pulp ticket, but suffice to say, some things rely on files being in certain places. My particular case is running a workshop with a bunch of people using Atom; either I'd need to come up with a custom pulp build --json-errors --no-psa (IDE integration), pulp psci and pulp test (wrapping each in an npm package script) or, if it's less trouble, move the PureScript files to a recognised spot like I have in this PR.

In any case I'm happy either way whether you choose to accept this; I can run the workshop off a fork of this repo. I just can't help but think that other people will hit the problems I did. :sweat_drops:

damncabbage commented 8 years ago

(This includes the change from #9; accepting this would close that.)

alexmingoia commented 8 years ago

Sounds good to me. :+1: Thanks for this.